Fix Emacs crash in mime-view
authorvitaly <vitaly>
Tue, 26 May 2009 14:59:24 +0000 (14:59 +0000)
committervitaly <vitaly>
Tue, 26 May 2009 14:59:24 +0000 (14:59 +0000)
Emacs crashes with segmentation fault when mime-view tries to display malformed
base64 attach like this one:

Content-Type: text/plain
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="dashik.V4S"

Attachment is a binary file, but content-type is set to text/plain. Function
decode-coding-string crashes in such sutuation when encoding set to x-ctext.
Default encoding in APEL is x-unknown, but Wl reassigns it to x-ctext to make
summary buffer display non-ascii characters in message correctly. It is not
necessary to do for invalid attachments, so put default-mime-charset back to
x-unknown while displaying entities.

elmo/elmo-mime.el

index 5ccc1d2..c9c1028 100644 (file)
@@ -80,7 +80,8 @@ use for keymap of representation buffer.")
                                              &optional
                                              original-major-mode
                                              keymap)
-  (let ((elmo-message-displaying t))
+  (let ((elmo-message-displaying t)
+       (default-mime-charset 'x-unknown))
     (mime-display-message entity
                          preview-buffer
                          nil