* elmo-localdir.el (elmo-folder-append-buffer): Fix interface.
[elisp/wanderlust.git] / elmo / elmo-pop3.el
index 8345095..afc7cbd 100644 (file)
@@ -197,8 +197,7 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
     (goto-char (point-min))
     (setq elmo-pop3-read-point (point))
     (elmo-pop3-debug "SEND: %s\n" (if no-log "<NO LOGGING>" command))
-    (process-send-string process command)
-    (process-send-string process "\r\n")))
+    (process-send-string process (concat command "\r\n"))))
 
 (defun elmo-pop3-read-response (process &optional not-command)
   ;; buffer is in case for process is dead.
@@ -426,8 +425,7 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
       (if (null (elmo-pop3-read-response process))
          (error "POP LIST command failed"))
       (if (null (setq response
-                     (elmo-pop3-read-contents
-                      (current-buffer) process)))
+                     (elmo-pop3-read-contents process)))
          (error "POP LIST command failed"))
       ;; POP server always returns a sequence of serial numbers.
       (setq count (elmo-pop3-parse-list-response response))
@@ -439,13 +437,12 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
        (elmo-pop3-send-command process "uidl")
        (unless (elmo-pop3-read-response process)
          (error "POP UIDL failed"))
-       (unless (setq response (elmo-pop3-read-contents
-                               (current-buffer) process))
+       (unless (setq response (elmo-pop3-read-contents process))
          (error "POP UIDL failed"))
        (elmo-pop3-parse-uidl-response response)))))
 
-(defun elmo-pop3-read-contents (buffer process)
-  (with-current-buffer buffer
+(defun elmo-pop3-read-contents (process)
+  (with-current-buffer (process-buffer process)
     (let ((case-fold-search nil)
          match-end)
       (goto-char elmo-pop3-read-point)
@@ -642,9 +639,9 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
    (t
     nil)))
 
-(defun elmo-pop3-retrieve-headers (buffer tobuffer process articles)
+(defun elmo-pop3-retrieve-headers (process tobuffer articles)
   (save-excursion
-    (set-buffer buffer)
+    (set-buffer (process-buffer process))
     (erase-buffer)
     (let ((number (length articles))
          (count 0)
@@ -667,7 +664,6 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
            (accept-process-output process 1))
          (discard-input)
          (while (progn
-                  (set-buffer buffer)
                   (goto-char last-point)
                   ;; Count replies.
                   (while (elmo-pop3-next-result-arrived-p)
@@ -682,10 +678,8 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
            (accept-process-output process 1)
 ;;;        (accept-process-output process)
            (discard-input))))
-      ;; Remove all "\r"'s.
-      (goto-char (point-min))
-      (while (search-forward "\r\n" nil t)
-       (replace-match "\n"))
+      ;; Replace all CRLF with LF.
+      (elmo-delete-cr-buffer)
       (copy-to-buffer tobuffer (point-min) (point-max)))))
 
 (luna-define-method elmo-folder-msgdb-create ((folder elmo-pop3-folder)
@@ -696,32 +690,27 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
       (elmo-pop3-sort-msgdb-by-original-number
        folder
        (elmo-pop3-msgdb-create-by-header
+       folder
        process
        numlist
        flag-table
        (if (elmo-pop3-folder-use-uidl-internal folder)
            (elmo-pop3-folder-location-alist-internal folder)))))))
 
-(defun elmo-pop3-sort-overview-by-original-number (overview loc-alist)
-  (if loc-alist
-      (sort overview
-           (lambda (ent1 ent2)
-             (< (elmo-pop3-uidl-to-number
-                 (cdr (assq (elmo-msgdb-overview-entity-get-number ent1)
-                            loc-alist)))
-                (elmo-pop3-uidl-to-number
-                 (cdr (assq (elmo-msgdb-overview-entity-get-number ent2)
-                            loc-alist))))))
-    overview))
-
 (defun elmo-pop3-sort-msgdb-by-original-number (folder msgdb)
-  (message "Sorting...")
-  (let ((overview (elmo-msgdb-get-overview msgdb)))
-    (setq overview (elmo-pop3-sort-overview-by-original-number
-                   overview
-                   (elmo-pop3-folder-location-alist-internal folder)))
-    (message "Sorting...done")
-    (list overview (nth 1 msgdb)(nth 2 msgdb)(nth 3 msgdb))))
+  (let ((location-alist (elmo-pop3-folder-location-alist-internal folder)))
+    (when location-alist
+      (elmo-msgdb-sort-entities
+       msgdb
+       (lambda (ent1 ent2 loc-alist)
+        (< (elmo-pop3-uidl-to-number
+            (cdr (assq (elmo-message-entity-number ent1)
+                       loc-alist)))
+           (elmo-pop3-uidl-to-number
+            (cdr (assq (elmo-message-entity-number ent2)
+                       loc-alist)))))
+       location-alist))
+    msgdb))
 
 (defun elmo-pop3-uidl-to-number (uidl)
   (string-to-number (elmo-get-hash-val uidl
@@ -735,9 +724,9 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
   (elmo-get-hash-val (format "#%d" number)
                     elmo-pop3-size-hash))
 
-(defun elmo-pop3-msgdb-create-by-header (process numlist
-                                                flag-table
-                                                loc-alist)
+(defun elmo-pop3-msgdb-create-by-header (folder process numlist
+                                               flag-table
+                                               loc-alist)
   (let ((tmp-buffer (get-buffer-create " *ELMO Overview TMP*")))
     (with-current-buffer (process-buffer process)
       (if loc-alist ; use uidl.
@@ -748,10 +737,10 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
                  (lambda (number)
                    (elmo-pop3-uidl-to-number (cdr (assq number loc-alist))))
                  numlist))))
-      (elmo-pop3-retrieve-headers (process-buffer process)
-                                 tmp-buffer process numlist)
+      (elmo-pop3-retrieve-headers process tmp-buffer numlist)
       (prog1
          (elmo-pop3-msgdb-create-message
+          folder
           tmp-buffer
           process
           (length numlist)
@@ -759,15 +748,16 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
           flag-table loc-alist)
        (kill-buffer tmp-buffer)))))
 
-(defun elmo-pop3-msgdb-create-message (buffer
+(defun elmo-pop3-msgdb-create-message (folder
+                                      buffer
                                       process
                                       num
                                       numlist
                                       flag-table
                                       loc-alist)
   (save-excursion
-    (let (beg overview number-alist mark-alist
-             entity i number message-id gmark seen size)
+    (let ((new-msgdb (elmo-make-msgdb))
+         beg entity i number message-id flags)
       (set-buffer buffer)
       (elmo-set-buffer-multibyte default-enable-multibyte-characters)
       (goto-char (point-min))
@@ -781,50 +771,36 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
          (save-restriction
            (narrow-to-region beg (point))
            (setq entity
-                 (elmo-msgdb-create-overview-from-buffer
+                 (elmo-msgdb-create-message-entity-from-buffer
+                  (elmo-msgdb-message-entity-handler new-msgdb)
                   (car numlist)))
            (setq numlist (cdr numlist))
            (when entity
-             (setq overview
-                   (elmo-msgdb-append-element
-                    overview entity))
              (with-current-buffer (process-buffer process)
-               (elmo-msgdb-overview-entity-set-size
+               (elmo-message-entity-set-field
                 entity
+                'size
                 (string-to-number
                  (elmo-pop3-number-to-size
-                  (elmo-msgdb-overview-entity-get-number entity))))
+                  (elmo-message-entity-number entity))))
                (if (setq number
                          (car
                           (rassoc
                            (elmo-pop3-number-to-uidl
-                            (elmo-msgdb-overview-entity-get-number entity))
+                            (elmo-message-entity-number entity))
                            loc-alist)))
-                   (elmo-msgdb-overview-entity-set-number entity number)))
-             (setq number-alist
-                   (elmo-msgdb-number-add
-                    number-alist
-                    (elmo-msgdb-overview-entity-get-number entity)
-                    (car entity)))
-             (setq message-id (car entity))
-             (if (setq gmark (or (elmo-msgdb-global-mark-get message-id)
-                                 (elmo-msgdb-mark
-                                  (elmo-flag-table-get flag-table message-id)
-                                  (elmo-file-cache-status
-                                   (elmo-file-cache-get message-id))
-                                  'new)))
-                 (setq mark-alist
-                       (elmo-msgdb-mark-append
-                        mark-alist
-                        (elmo-msgdb-overview-entity-get-number entity)
-                        gmark))))))
+                   (elmo-message-entity-set-number entity number)))
+             (setq message-id (elmo-message-entity-field entity 'message-id)
+                   flags (elmo-flag-table-get flag-table message-id))
+             (elmo-global-flags-set flags folder number message-id)
+             (elmo-msgdb-append-entity new-msgdb entity flags))))
        (when (> num elmo-display-progress-threshold)
          (setq i (1+ i))
          (if (or (zerop (% i 5)) (= i num))
              (elmo-display-progress
               'elmo-pop3-msgdb-create-message "Creating msgdb..."
               (/ (* i 100) num)))))
-      (list overview number-alist mark-alist))))
+      new-msgdb)))
 
 (defun elmo-pop3-read-body (process outbuf)
   (with-current-buffer (process-buffer process)
@@ -897,6 +873,7 @@ If IF-EXISTS is `any-exists', get BIFF session or normal session if exists."
        (while (re-search-forward "^\\." nil t)
          (replace-match "")
          (forward-line))
+       (elmo-delete-cr-buffer)
        response))))
 
 (defun elmo-pop3-delete-msg (process number loc-alist)