int run_end_begin_glyphs);
static void redisplay_output_display_block (struct window *w, struct display_line *dl,
int block, int start, int end, int start_pixpos,
- int cursor_start, int cursor_width,
+ int cursor_start, int cursor_width,
int cursor_height);
-static void redisplay_normalize_display_box (struct display_box* dest,
+static void redisplay_normalize_display_box (struct display_box* dest,
struct display_glyph_area* src);
static int redisplay_display_boxes_in_window_p (struct window* w,
struct display_box* db,
struct display_glyph_area* dga);
-static void redisplay_clear_clipped_region (Lisp_Object locale, face_index findex,
- struct display_box* dest,
- struct display_glyph_area* glyphsrc,
+static void redisplay_clear_clipped_region (Lisp_Object locale, face_index findex,
+ struct display_box* dest,
+ struct display_glyph_area* glyphsrc,
int fullheight_p, Lisp_Object);
/*****************************************************************************
/* Do not compare the values of bufpos and endpos. They do not
affect the display characteristics. */
+ /* Note: (hanoi 6) spends 95% of its time in redisplay, and about
+ 30% here. Not using bitfields for rune.type alone gives a redisplay
+ speed up of 10%.
+
+ #### In profile arcs run of a normal Gnus session this function
+ is run 6.76 million times, only to return 1 in 6.73 million of
+ those.
+
+ In addition a quick look GCC sparc assembly shows that GCC is not
+ doing a good job here.
+ 1. The function is not inlined (too complicated?)
+ 2. It seems to be reloading the crb and drb variables all the
+ time.
+ 3. It doesn't seem to notice that the second half of these if's
+ are really a switch statement.
+
+ So I (JV) conjecture
+
+ #### It would really be worth it to arrange for this function to
+ be (almost) a single call to memcmp. */
+
if ((crb->findex != drb->findex) ||
(WINDOW_FACE_CACHEL_DIRTY (w, drb->findex)))
return 0;
(crb->object.hline.thickness != drb->object.hline.thickness ||
crb->object.hline.yoffset != drb->object.hline.yoffset))
return 0;
- else if (crb->type == RUNE_DGLYPH &&
+ else if (crb->type == RUNE_DGLYPH &&
(!EQ (crb->object.dglyph.glyph, drb->object.dglyph.glyph) ||
!EQ (crb->object.dglyph.extent, drb->object.dglyph.extent) ||
crb->object.dglyph.xoffset != drb->object.dglyph.xoffset))
up-to-date. */
if (GLYPH_CACHEL_DIRTYP (w, gindex))
return 0;
- else
+ else
return 1;
}
else
if (x < ddl->bounds.left_in)
{
findex = ddl->left_margin_findex ?
- ddl->left_margin_findex
+ ddl->left_margin_findex
: get_builtin_face_cache_index (w, Vleft_margin_face);
}
else if (x < ddl->bounds.right_in)
else if (x < ddl->bounds.right_out)
{
findex = ddl->right_margin_findex ?
- ddl->right_margin_findex
+ ddl->right_margin_findex
: get_builtin_face_cache_index (w, Vright_margin_face);
}
else
region or if it was a block of a different type, then
output the entire ddb. Otherwise, compare cdb and
ddb and output only the changed region. */
- if (!force && cdb && ddb->type == cdb->type
+ if (!force && cdb && ddb->type == cdb->type
/* If there was no buffer being display before the
compare anyway as we might be outputting a gutter. */
- &&
+ &&
(b == old_b || !old_b))
{
must_sync |= compare_display_blocks (w, cdl, ddl, old_block,
cursor_start, cursor_width,
cursor_height);
}
-
+
start_pixpos = next_start_pixpos;
}
}
y -= MODELINE_SHADOW_THICKNESS (w);
height += (2 * MODELINE_SHADOW_THICKNESS (w));
}
-
+
if (window_is_leftmost (w))
clear_left_border (w, y, height);
if (window_is_rightmost (w))
}
}
- while ((up ? (cur_dl < Dynarr_length (cla)) : (cur_dl >= 0)))
+ while (up ? (cur_dl < Dynarr_length (cla)) : (cur_dl >= 0))
{
dl = Dynarr_atp (cla, cur_dl);
db = get_display_block_from_line (dl, TEXT);
cachel->x + cachel->width > x && cachel->x < x + width
&&
cachel->y + cachel->height > y && cachel->y < y + height
- &&
+ &&
!EQ (cachel->subwindow, ignored_window))
{
unmap_subwindow (cachel->subwindow);
}
}
-static void redisplay_unmap_subwindows_except_us (struct frame* f, int x, int y, int width,
+static void redisplay_unmap_subwindows_except_us (struct frame* f, int x, int y, int width,
int height, Lisp_Object subwindow)
{
if (Dynarr_length (FRAME_SUBWINDOW_CACHE (f)))
pixmaps, backgrounds etc.
****************************************************************************/
void
-redisplay_output_subwindow (struct window *w,
+redisplay_output_subwindow (struct window *w,
Lisp_Object image_instance,
struct display_box* db, struct display_glyph_area* dga,
face_index findex, int cursor_start, int cursor_width,
int cursor_height)
{
- struct Lisp_Image_Instance *p = XIMAGE_INSTANCE (image_instance);
+ Lisp_Image_Instance *p = XIMAGE_INSTANCE (image_instance);
Lisp_Object window;
struct display_glyph_area sdga;
- dga->height = IMAGE_INSTANCE_SUBWINDOW_HEIGHT (p);
- dga->width = IMAGE_INSTANCE_SUBWINDOW_WIDTH (p);
+ dga->height = IMAGE_INSTANCE_HEIGHT (p);
+ dga->width = IMAGE_INSTANCE_WIDTH (p);
+
+ /* The first thing we are going to do is update the display
+ characteristics of the subwindow. This also clears the dirty
+ flags as a side effect. */
+ update_subwindow (image_instance);
/* This makes the glyph area fit into the display area. */
if (!redisplay_normalize_glyph_area (db, dga))
cases.*/
sdga.xoffset = -dga->xoffset;
sdga.yoffset = -dga->yoffset;
- sdga.height = IMAGE_INSTANCE_SUBWINDOW_HEIGHT (p);
- sdga.width = IMAGE_INSTANCE_SUBWINDOW_WIDTH (p);
-
+ sdga.height = IMAGE_INSTANCE_HEIGHT (p);
+ sdga.width = IMAGE_INSTANCE_WIDTH (p);
+
if (redisplay_display_boxes_in_window_p (w, db, &sdga) < 0)
{
map_subwindow (image_instance, db->xpos, db->ypos, dga);
else
{
sdga.xoffset = sdga.yoffset = 0;
- map_subwindow (image_instance, db->xpos - dga->xoffset,
+ map_subwindow (image_instance, db->xpos - dga->xoffset,
db->ypos - dga->yoffset, &sdga);
}
}
redisplay_output_layout
Output a widget hierarchy. This can safely call itself recursively.
+
+ The complexity of outputting layouts is deciding whether to do it or
+ not. Consider a layout enclosing some text, the text changes and is
+ marked as dirty, but the enclosing layout has not been marked as
+ dirty so no updates occur and the text will potentially be truncated.
+ Alternatively we hold a back pointer in the image instance to the
+ parent and mark the parent as dirty. But the layout code assumes that
+ if the layout is dirty then the whole layout should be redisplayed,
+ so we then get lots of flashing even though only the text has changed
+ size. Of course if the text shrinks in size then we do actually need
+ to redisplay the layout to repaint the exposed area. So what happens
+ if we make a non-structural change like changing color? Either we
+ redisplay everything, or we redisplay nothing. These are exactly the
+ issues lwlib has to grapple with. We really need to know what has
+ actually changed and make a layout decision based on that. We also
+ really need to know what has changed so that we can only make the
+ neccessary changes in update_subwindow. This has all now been
+ implemented, Viva la revolution!
****************************************************************************/
void
-redisplay_output_layout (struct window *w,
+redisplay_output_layout (struct window *w,
Lisp_Object image_instance,
struct display_box* db, struct display_glyph_area* dga,
face_index findex, int cursor_start, int cursor_width,
int cursor_height)
{
- struct Lisp_Image_Instance *p = XIMAGE_INSTANCE (image_instance);
+ Lisp_Image_Instance *p = XIMAGE_INSTANCE (image_instance);
Lisp_Object window, rest;
Emchar_dynarr *buf = Dynarr_new (Emchar);
struct frame *f = XFRAME (w->frame);
int layout_height, layout_width;
/* We bogusly don't take f->extents_changed and f->glyphs_changed
into account. This is because if we do we always redisplay the
- entire layout. So far I have seen no ill effects to we'll see. */
- int frame_changed = (f->buffers_changed ||
- f->clip_changed ||
- f->faces_changed ||
- f->frame_changed ||
- f->modeline_changed ||
- f->subwindows_changed ||
- f->windows_changed ||
- f->windows_structure_changed);
+ entire layout. So far I have seen no ill effects so we'll see. */
+ int frame_really_changed = (f->buffers_changed ||
+ f->clip_changed ||
+ f->faces_changed ||
+ f->frame_changed ||
+ f->modeline_changed ||
+ f->subwindows_changed ||
+ f->windows_changed ||
+ f->windows_structure_changed);
XSETWINDOW (window, w);
- layout_height = glyph_height (image_instance, Qnil, findex, window);
- layout_width = glyph_width (image_instance, Qnil, findex, window);
+ layout_height = glyph_height (image_instance, window);
+ layout_width = glyph_width (image_instance, window);
dga->height = layout_height;
dga->width = layout_width;
/* Highly dodgy optimization. We want to only output the whole
layout if we really have to. */
- if (frame_changed || IMAGE_INSTANCE_DIRTYP (p))
+ if (frame_really_changed
+ || IMAGE_INSTANCE_LAYOUT_CHANGED (p)
+ || IMAGE_INSTANCE_WIDGET_FACE_CHANGED (p)
+ || IMAGE_INSTANCE_SIZE_CHANGED (p)
+ || IMAGE_INSTANCE_WIDGET_ITEMS_CHANGED (p))
{
/* First clear the area we are drawing into. This is the easiest
thing to do since we have many gaps that we have to make sure are
filled in. */
redisplay_clear_clipped_region (window, findex, db, dga, 1, Qnil);
-
+
/* Output a border if required */
if (!NILP (IMAGE_INSTANCE_LAYOUT_BORDER (p)))
{
enum edge_style style;
int ypos = db->ypos;
int height = dga->height;
-
+
if (dga->xoffset >= 0)
edges |= EDGE_LEFT;
if (dga->width - dga->xoffset == layout_width)
edges |= EDGE_TOP;
if (dga->height - dga->yoffset == layout_height)
edges |= EDGE_BOTTOM;
-
+
if (EQ (IMAGE_INSTANCE_LAYOUT_BORDER (p), Qetched_in))
style = EDGE_ETCHED_IN;
else if (EQ (IMAGE_INSTANCE_LAYOUT_BORDER (p), Qetched_out))
else
style = EDGE_BEVEL_OUT;
- MAYBE_DEVMETH (d, bevel_area,
+ MAYBE_DEVMETH (d, bevel_area,
(w, findex, db->xpos,
- ypos,
+ ypos,
dga->width, height, 2, edges, style));
}
}
-
+
/* This shrinks the display box to exactly enclose the glyph
area. */
redisplay_normalize_display_box (db, dga);
/* First determine if the image is visible at all */
if (IMAGE_INSTANCEP (child))
{
- struct Lisp_Image_Instance* childii = XIMAGE_INSTANCE (child);
+ Lisp_Image_Instance* childii = XIMAGE_INSTANCE (child);
/* The enclosing layout offsets are +ve at this point */
struct display_glyph_area cdga;
cdga.xoffset = IMAGE_INSTANCE_XOFFSET (childii) - dga->xoffset;
cdga.yoffset = IMAGE_INSTANCE_YOFFSET (childii) - dga->yoffset;
- cdga.width = glyph_width (child, Qnil, findex, window);
- cdga.height = glyph_height (child, Qnil, findex, window);
+ cdga.width = glyph_width (child, window);
+ cdga.height = glyph_height (child, window);
/* Although normalization is done by the output routines
we have to do it here so that they don't try and
{
/* #### This is well hacked and could use some
generalisation.*/
- if (redisplay_normalize_glyph_area (&cdb, &cdga)
- &&
- (frame_changed || IMAGE_INSTANCE_DIRTYP (childii)))
+ if (redisplay_normalize_glyph_area (&cdb, &cdga)
+ &&
+ (frame_really_changed || IMAGE_INSTANCE_DIRTYP (childii)))
{
struct display_line dl; /* this is fake */
Lisp_Object string =
IMAGE_INSTANCE_TEXT_STRING (childii);
convert_bufbyte_string_into_emchar_dynarr
(XSTRING_DATA (string), XSTRING_LENGTH (string), buf);
-
+
redisplay_normalize_display_box (&cdb, &cdga);
/* Offsets are now +ve again so be careful
when fixing up the display line. */
xzero (dl);
/* Munge boxes into display lines. */
dl.ypos = (cdb.ypos - cdga.yoffset)
- + glyph_ascent (child, Qnil, findex, window);
- dl.ascent = glyph_ascent (child, Qnil, findex, window);
- dl.descent = glyph_descent (child, Qnil, findex, window);
+ + glyph_ascent (child, window);
+ dl.ascent = glyph_ascent (child, window);
+ dl.descent = glyph_descent (child, window);
dl.top_clip = cdga.yoffset;
dl.clip = (dl.ypos + dl.descent) - (cdb.ypos + cdb.height);
/* output_string doesn't understand offsets in
}
}
break;
-
+
case IMAGE_MONO_PIXMAP:
case IMAGE_COLOR_PIXMAP:
- if (frame_changed || IMAGE_INSTANCE_DIRTYP (childii))
+ if (frame_really_changed || IMAGE_INSTANCE_DIRTYP (childii))
redisplay_output_pixmap (w, child, &cdb, &cdga, findex,
0, 0, 0, 0);
break;
-
+
case IMAGE_WIDGET:
case IMAGE_SUBWINDOW:
- if (frame_changed || IMAGE_INSTANCE_DIRTYP (childii))
+ if (frame_really_changed || IMAGE_INSTANCE_DIRTYP (childii))
redisplay_output_subwindow (w, child, &cdb, &cdga, findex,
0, 0, 0);
break;
-
+
case IMAGE_LAYOUT:
redisplay_output_layout (w, child, &cdb, &cdga, findex,
0, 0, 0);
break;
-
+
case IMAGE_NOTHING:
/* nothing is as nothing does */
break;
-
+
case IMAGE_POINTER:
default:
abort ();
}
}
}
+
+ /* Update any display properties. I'm not sure whether this actually
+ does anything for layouts except clear the changed flags. */
+ update_subwindow (image_instance);
+
Dynarr_free (buf);
}
output a pixmap.
****************************************************************************/
void
-redisplay_output_pixmap (struct window *w,
+redisplay_output_pixmap (struct window *w,
Lisp_Object image_instance,
struct display_box* db, struct display_glyph_area* dga,
face_index findex, int cursor_start, int cursor_width,
{
struct frame *f = XFRAME (w->frame);
struct device *d = XDEVICE (f->device);
- struct Lisp_Image_Instance *p = XIMAGE_INSTANCE (image_instance);
+ Lisp_Image_Instance *p = XIMAGE_INSTANCE (image_instance);
Lisp_Object window;
XSETWINDOW (window, w);
if (!offset_bitmap)
{
redisplay_clear_clipped_region (window, findex,
- db, dga,
+ db, dga,
(int)IMAGE_INSTANCE_PIXMAP_MASK (p),
Qnil);
/* #### This isn't quite right for when this function is called
from the toolbar code. */
-
+
/* Don't use a backing pixmap in the border area */
if (x >= FRAME_LEFT_BORDER_END (f)
&& x < FRAME_RIGHT_BORDER_START (f)
&& y < FRAME_BOTTOM_BORDER_START (f))
{
Lisp_Object temp;
-
+
if (w)
{
temp = WINDOW_FACE_CACHEL_BACKGROUND_PIXMAP (w, findex);
-
+
if (IMAGE_INSTANCEP (temp)
&& IMAGE_INSTANCE_PIXMAP_TYPE_P (XIMAGE_INSTANCE (temp)))
{
else
{
temp = FACE_BACKGROUND_PIXMAP (Vdefault_face, locale);
-
+
if (IMAGE_INSTANCEP (temp)
&& IMAGE_INSTANCE_PIXMAP_TYPE_P (XIMAGE_INSTANCE (temp)))
{
background_pixmap = temp;
}
}
- }
+ }
if (!UNBOUNDP (background_pixmap) &&
XIMAGE_INSTANCE_PIXMAP_DEPTH (background_pixmap) == 0)
fcolor = (w ?
WINDOW_FACE_CACHEL_BACKGROUND (w, findex) :
FACE_BACKGROUND (Vdefault_face, locale));
-
+
}
-
+
if (UNBOUNDP (background_pixmap))
background_pixmap = Qnil;
-
- DEVMETH (d, clear_region,
+
+ DEVMETH (d, clear_region,
(locale, d, f, findex, x, y, width, height, fcolor, bcolor, background_pixmap));
}
around with by altering these. glyphsrc should be normalized.
****************************************************************************/
static void
-redisplay_clear_clipped_region (Lisp_Object window, face_index findex,
- struct display_box* dest, struct display_glyph_area* glyphsrc,
+redisplay_clear_clipped_region (Lisp_Object window, face_index findex,
+ struct display_box* dest, struct display_glyph_area* glyphsrc,
int fullheight_p, Lisp_Object ignored_subwindow)
{
/* assume dest->xpos >= 0 */
}
else
{
- int yoffset = (glyphsrc->yoffset > 0 ? glyphsrc->yoffset : 0);
-
+ int yoffset = (glyphsrc->yoffset > 0 ? glyphsrc->yoffset : 0);
+
/* We need to make sure that subwindows are unmapped from the
whole area. */
redisplay_unmap_subwindows_except_us (f, clear_x, dest->ypos,
{
redisplay_clear_region (window, findex, clear_x, dest->ypos,
glyphsrc->width, yoffset);
-
+
}
/* Then the bottom box */
if (yoffset + glyphsrc->height < dest->height)
{
redisplay_clear_region (window, findex, clear_x,
dest->ypos + yoffset + glyphsrc->height,
- glyphsrc->width,
+ glyphsrc->width,
dest->height - (yoffset + glyphsrc->height));
}
Calculate the visible box for displaying src in dest.
****************************************************************************/
int
-redisplay_normalize_glyph_area (struct display_box* dest,
+redisplay_normalize_glyph_area (struct display_box* dest,
struct display_glyph_area* glyphsrc)
{
if (dest->xpos + glyphsrc->xoffset > dest->xpos + dest->width
}
static void
-redisplay_normalize_display_box (struct display_box* dest,
+redisplay_normalize_display_box (struct display_box* dest,
struct display_glyph_area* glyphsrc)
{
/* Adjust the destination area. At the end of this the destination
|| db->ypos + db->height > bottom)
/* We are not displaying in a window at all */
return 0;
-
+
if (db->xpos + dga->xoffset >= left
&&
db->ypos + dga->yoffset >= top
int
redisplay_calculate_display_boxes (struct display_line *dl, int xpos,
int xoffset, int start_pixpos, int width,
- struct display_box* dest,
+ struct display_box* dest,
struct display_glyph_area* src)
{
dest->xpos = xpos;
else
{
int height = ypos2 - ypos1;
-
+
if (height)
{
Lisp_Object window;
int bflag = 0 ; /* (window_needs_vertical_divider (w) ? 0 : 1);*/
layout_bounds bounds;
-
+
bounds = calculate_display_line_boundaries (w, bflag);
XSETWINDOW (window, w);
if (window_is_leftmost (w))
redisplay_clear_region (window, DEFAULT_INDEX, FRAME_LEFT_BORDER_START (f),
ypos1, FRAME_BORDER_WIDTH (f), height);
-
+
if (bounds.left_in - bounds.left_out > 0)
redisplay_clear_region (window,
get_builtin_face_cache_index (w, Vleft_margin_face),
bounds.left_out, ypos1,
bounds.left_in - bounds.left_out, height);
-
+
if (bounds.right_in - bounds.left_in > 0)
- redisplay_clear_region (window,
+ redisplay_clear_region (window,
DEFAULT_INDEX,
bounds.left_in, ypos1,
bounds.right_in - bounds.left_in, height);
-
+
if (bounds.right_out - bounds.right_in > 0)
redisplay_clear_region (window,
get_builtin_face_cache_index (w, Vright_margin_face),
bounds.right_in, ypos1,
bounds.right_out - bounds.right_in, height);
-
+
if (window_is_rightmost (w))
redisplay_clear_region (window, DEFAULT_INDEX, FRAME_RIGHT_BORDER_START (f),
ypos1, FRAME_BORDER_WIDTH (f), height);
style = EDGE_BEVEL_OUT;
}
- MAYBE_DEVMETH (d, bevel_area,
+ MAYBE_DEVMETH (d, bevel_area,
(w, MODELINE_INDEX, x, y, width, height, shadow_thickness,
EDGE_ALL, style));
}
projects / chise / xemacs-chise.git.1 / blobdiff