* wl-score.el (wl-score-followup): Remove verbose comment (same as docstring).
[elisp/wanderlust.git] / wl / wl-score.el
index f1ea581..328c5bd 100644 (file)
@@ -34,6 +34,7 @@
 (require 'wl-vars)
 (require 'wl-util)
 (eval-when-compile
+  (require 'cl)                                ; cadaar, cddaar
   (require 'elmo-msgdb))               ; for inline functions
 
 (defvar wl-score-edit-header-char
@@ -166,7 +167,7 @@ Remove Re, Was, Fwd etc."
 (defun wl-score-overview-entity-get-lines (entity)
   (let ((lines (elmo-message-entity-field entity 'lines)))
     (and lines
-        (string-to-int lines))))
+        (string-to-number lines))))
 
 (defun wl-score-overview-entity-get-xref (entity)
   (or (elmo-message-entity-field entity 'xref)
@@ -176,8 +177,12 @@ Remove Re, Was, Fwd etc."
   (not (or (string< s1 s2)
           (string= s1 s2))))
 
-(defsubst wl-score-ov-entity-get (entity index &optional extra decode)
-  (elmo-message-entity-field entity (if extra (intern extra) index) decode))
+(defsubst wl-score-ov-entity-get (entity index &optional extra)
+  (elmo-message-entity-field entity (if extra (intern extra) index)
+                            ;; FIXME
+                            (if (or (eq index 'to) (eq index 'cc))
+                                'string
+                              nil)))
 
 (defun wl-score-string< (a1 a2)
   (string-lessp (wl-score-ov-entity-get (car a1) wl-score-index)
@@ -367,7 +372,7 @@ Set `wl-score-cache' nil."
 (defun wl-score-headers (scores &optional force-msgs not-add)
   (let* ((elmo-mime-charset wl-summary-buffer-mime-charset)
         (folder wl-summary-buffer-elmo-folder)
-        (now (wl-day-number (current-time-string)))
+        (now (elmo-time-to-days (current-time)))
         (expire (and wl-score-expiry-days
                      (- now wl-score-expiry-days)))
         (wl-score-stop-add-entry not-add)
@@ -533,14 +538,14 @@ Set `wl-score-cache' nil."
       (setq extras (cdr extras)))
     nil))
 
-(defmacro wl-score-put-alike ()
-  (` (elmo-set-hash-val (format "#%d" (wl-count-lines))
-                       alike
-                       wl-score-alike-hashtb)))
+(defmacro wl-score-put-alike (alike)
+  `(elmo-set-hash-val (format "#%d" (wl-count-lines))
+                     ,alike
+                     wl-score-alike-hashtb))
 
-(defmacro wl-score-get-alike ()
-  (` (elmo-get-hash-val (format "#%d" (wl-count-lines))
-                       wl-score-alike-hashtb)))
+(defsubst wl-score-get-alike ()
+  (elmo-get-hash-val (format "#%d" (wl-count-lines))
+                    wl-score-alike-hashtb))
 
 (defun wl-score-insert-header (header messages &optional extra-header)
   (let ((mime-decode (nth 3 (assoc header wl-score-header-index)))
@@ -558,24 +563,25 @@ Set `wl-score-cache' nil."
       (make-local-variable 'wl-score-alike-hashtb)
       (setq wl-score-alike-hashtb (elmo-make-hash (* (length messages) 2)))
       (when mime-decode
-       (elmo-set-buffer-multibyte default-enable-multibyte-characters))
+       (set-buffer-multibyte default-enable-multibyte-characters))
       (let (art last this alike)
        (while (setq art (pop messages))
          (setq this (wl-score-ov-entity-get (car art)
                                             wl-score-index
                                             extra-header))
-         (and this (setq this (std11-unfold-string this)))
+         (when (stringp this)
+           (setq this (std11-unfold-string this)))
          (if (equal last this)
              ;; O(N*H) cons-cells used here, where H is the number of
              ;; headers.
              (wl-push art alike)
            (when last
-             (wl-score-put-alike)
+             (wl-score-put-alike alike)
              (insert last ?\n))
            (setq alike (list art)
                  last this)))
        (when last
-         (wl-score-put-alike)
+         (wl-score-put-alike alike)
          (insert last ?\n))
        (when mime-decode
          (decode-mime-charset-region (point-min) (point-max)
@@ -705,7 +711,6 @@ Set `wl-score-cache' nil."
 
 (defun wl-score-followup (scores header now expire &optional thread)
   "Insert the unique message headers in the buffer."
-  ;; Insert the unique message headers in the buffer.
   (let ((wl-score-index (nth 2 (assoc header wl-score-header-index)))
        (all-scores scores)
        entries alist messages
@@ -754,7 +759,7 @@ Set `wl-score-cache' nil."
                               expire
                               (< expire
                                  (setq day
-                                       (wl-day-number
+                                       (elmo-time-to-days
                                         (elmo-message-entity-field
                                          (car art) 'date))))))
                  (when (setq new (wl-score-add-followups
@@ -780,7 +785,7 @@ Set `wl-score-cache' nil."
       (list (cons "references" news)))))
 
 (defun wl-score-add-followups (header score scores alist &optional thread day)
-  (let* ((id (car header))
+  (let* ((id (elmo-message-entity-field header 'message-id))
         (scores (car scores))
         entry dont)
     (when id
@@ -792,7 +797,7 @@ Set `wl-score-cache' nil."
             (setq dont t)))
       (unless dont
        (let ((entry (list id score
-                          (or day (wl-day-number (current-time-string))) 's)))
+                          (or day (elmo-time-to-days (current-time))) 's)))
          (unless (or thread wl-score-stop-add-entry)
            (wl-score-update-score-entry "references" entry alist))
          (wl-score-set 'touched '(t) alist)
@@ -810,7 +815,7 @@ Set `wl-score-cache' nil."
   "Automatically mark messages with score below SCORE as read."
   (interactive
    (list (or (and current-prefix-arg (prefix-numeric-value current-prefix-arg))
-            (string-to-int (read-string "Mark below: ")))))
+            (string-to-number (read-string "Mark below: ")))))
   (setq score (or score wl-summary-default-score 0))
   (wl-score-set 'mark (list score))
   (wl-score-set 'touched '(t))
@@ -821,7 +826,7 @@ Set `wl-score-cache' nil."
   "Automatically expunge messages with score below SCORE."
   (interactive
    (list (or (and current-prefix-arg (prefix-numeric-value current-prefix-arg))
-            (string-to-int (read-string "Expunge below: ")))))
+            (string-to-number (read-string "Expunge below: ")))))
   (setq score (or score wl-summary-default-score 0))
   (wl-score-set 'expunge (list score))
   (wl-score-set 'touched '(t)))
@@ -862,12 +867,12 @@ Set `wl-score-cache' nil."
                         (car entry)
                         (if increase "raise" "lower"))
                 (if (numberp match)
-                    (int-to-string match)
+                    (number-to-string match)
                   match)))
     ;; transform from string to int.
     (when (eq (nth 1 (assoc (car entry) wl-score-header-index))
              'wl-score-integer)
-      (setq match (string-to-int match)))
+      (setq match (string-to-number match)))
     ;; set score
     (if score
        (setq lscore rscore)
@@ -892,7 +897,7 @@ Set `wl-score-cache' nil."
     (wl-summary-score-effect (car entry) list (eq (nth 2 list) 'now)))))
 
 (defun wl-score-get-latest-msgs ()
-  (let* ((now (wl-day-number (current-time-string)))
+  (let* ((now (elmo-time-to-days (current-time)))
         (expire (and wl-score-expiry-days
                      (- now wl-score-expiry-days)))
         (rnumbers (reverse wl-summary-buffer-number-list))
@@ -902,11 +907,10 @@ Set `wl-score-cache' nil."
                                   nil t)
       (catch 'break
        (while rnumbers
-         (if (< (wl-day-number
-                 (elmo-message-entity-field
-                  (elmo-message-entity wl-summary-buffer-elmo-folder
-                                       (car rnumbers))
-                  'date))
+         (if (< (elmo-time-to-days
+                 (elmo-message-entity-field wl-summary-buffer-elmo-folder
+                                            (car rnumbers)
+                                            'date))
                 expire)
              (throw 'break t))
          (wl-push (car rnumbers) msgs)
@@ -920,7 +924,7 @@ Set `wl-score-cache' nil."
        (wl-score-ov-entity-get
         (elmo-message-entity wl-summary-buffer-elmo-folder
                              (wl-summary-message-number))
-        index extra decode))))
+        index extra))))
 
 (defun wl-score-kill-help-buffer ()
   (when (get-buffer "*Score Help*")
@@ -932,8 +936,7 @@ Set `wl-score-cache' nil."
   (setq wl-score-help-winconf (current-window-configuration))
   (let ((cur-win (selected-window))
        mes-win)
-    (save-excursion
-      (set-buffer (get-buffer-create "*Score Help*"))
+    (with-current-buffer (get-buffer-create "*Score Help*")
       (buffer-disable-undo (current-buffer))
       (delete-windows-on (current-buffer))
       (erase-buffer)
@@ -958,7 +961,7 @@ Set `wl-score-cache' nil."
            (delete-char -1)            ; the `\n' takes a char
            (insert "\n"))
          (setq pad (- width 3))
-         (setq format (concat "%c: %-" (int-to-string pad) "s"))
+         (setq format (concat "%c: %-" (number-to-string pad) "s"))
          (insert (format format (caar alist) (nth idx (car alist))))
          (setq alist (cdr alist))
          (setq i (1+ i)))
@@ -1057,7 +1060,7 @@ Set `wl-score-cache' nil."
 
          ;; read the score.
          (unless (or score increase)
-           (setq score (string-to-int (read-string "Set score: ")))))
+           (setq score (string-to-number (read-string "Set score: ")))))
       (message "")
       (wl-score-kill-help-buffer))
 
@@ -1075,7 +1078,7 @@ Set `wl-score-cache' nil."
           (perm (cond ((eq perm 'perm)
                        nil)
                       ((eq perm 'temp)
-                       (wl-day-number (current-time-string)))
+                       (elmo-time-to-days (current-time)))
                       ((eq perm 'now)
                        perm)))
           (new (list match score perm type extra)))
@@ -1166,64 +1169,59 @@ Set `wl-score-cache' nil."
       (wl-score-headers scores force-msgs not-add))))
 
 (defun wl-summary-score-update-all-lines (&optional update)
-  (let* ((alist wl-summary-scored)
-        (count (length alist))
-        (i 0)
-        (update-unread nil)
-        wl-summary-unread-message-hook
-        num score dels visible score-mark mark-alist)
+  (let ((alist wl-summary-scored)
+       (update-unread nil)
+       wl-summary-unread-message-hook
+       num score dels visible score-mark mark-alist)
     (save-excursion
-      (message "Updating score...")
-      (while alist
-       (setq num (caar alist)
-             score (cdar alist))
-       (when wl-score-debug
-         (message "Scored %d with %d" score num)
-         (wl-push (list (elmo-string (wl-summary-buffer-folder-name)) num score)
-               wl-score-trace))
-       (setq score-mark (wl-summary-get-score-mark num))
-       (and (setq visible (wl-summary-jump-to-msg num))
-            (wl-summary-set-score-mark score-mark))
-       (cond ((and wl-summary-expunge-below
-                   (< score wl-summary-expunge-below))
-              (wl-push num dels))
-             ((< score wl-summary-mark-below)
-              (if visible
-                  (wl-summary-mark-as-read num); opened
-                (setq update-unread t)
-                (wl-summary-mark-as-read num))) ; closed
-             ((and wl-summary-important-above
-                   (> score wl-summary-important-above))
-              (if (wl-thread-jump-to-msg num);; force open
-                  (wl-summary-mark-as-important num)))
-             ((and wl-summary-target-above
-                   (> score wl-summary-target-above))
-              (if visible
-                  (wl-summary-set-mark "*"))))
-       (setq alist (cdr alist))
-       (when (> count elmo-display-progress-threshold)
-         (setq i (1+ i))
-         (elmo-display-progress
-          'wl-summary-score-update-all-lines "Updating score..."
-          (/ (* i 100) count))))
-      (when dels
-       (dolist (del dels)
-         (elmo-message-set-flag wl-summary-buffer-elmo-folder
-                                del 'read))
-       (elmo-folder-kill-messages wl-summary-buffer-elmo-folder dels)
-       (wl-summary-delete-messages-on-buffer dels))
-      (when (and update update-unread)
-       ;; Update Folder mode
-       (wl-folder-set-folder-updated (wl-summary-buffer-folder-name)
-                                     (list
-                                      0
-                                      (let ((lst
-                                             (wl-summary-count-unread)))
-                                        (+ (car lst) (nth 1 lst)))
-                                      (elmo-folder-length
-                                       wl-summary-buffer-elmo-folder)))
-       (wl-summary-update-modeline))
-      (message "Updating score...done")
+      (elmo-with-progress-display (wl-update-score (length alist))
+         "Updating score"
+       (while alist
+         (setq num (caar alist)
+               score (cdar alist))
+         (when wl-score-debug
+           (message "Scored %d with %d" score num)
+           (wl-push (list (elmo-string (wl-summary-buffer-folder-name)) num score)
+                    wl-score-trace))
+         (setq score-mark (wl-summary-get-score-mark num))
+         (and (setq visible (wl-summary-jump-to-msg num))
+              (wl-summary-set-score-mark score-mark))
+         (cond ((and wl-summary-expunge-below
+                     (< score wl-summary-expunge-below))
+                (wl-push num dels))
+               ((< score wl-summary-mark-below)
+                (if visible
+                    (wl-summary-mark-as-read num); opened
+                  (setq update-unread t)
+                  (wl-summary-mark-as-read num))) ; closed
+               ((and wl-summary-important-above
+                     (> score wl-summary-important-above))
+                (if (wl-thread-jump-to-msg num);; force open
+                    (wl-summary-set-persistent-mark 'important num)))
+               ((and wl-summary-target-above
+                     (> score wl-summary-target-above))
+                (if visible
+                    (wl-summary-set-mark "*"))))
+         (setq alist (cdr alist))
+         (elmo-progress-notify 'wl-update-score))
+       (when dels
+         (dolist (del dels)
+           (elmo-message-unset-flag wl-summary-buffer-elmo-folder
+                                    del 'unread))
+         (elmo-folder-kill-messages wl-summary-buffer-elmo-folder dels)
+         (wl-summary-delete-messages-on-buffer dels))
+       (when (and update update-unread)
+         ;; Update Folder mode
+         (wl-folder-set-folder-updated (wl-summary-buffer-folder-name)
+                                       (list
+                                        0
+                                        (let ((flag-count
+                                               (wl-summary-count-unread)))
+                                          (or (cdr (assq 'unread flag-count))
+                                              0))
+                                        (elmo-folder-length
+                                         wl-summary-buffer-elmo-folder)))
+         (wl-summary-update-modeline)))
       dels)))
 
 (defun wl-score-edit-done ()
@@ -1320,7 +1318,7 @@ Entering Score mode calls the value of `wl-score-mode-hook'."
 (defun wl-score-edit-insert-date ()
   "Insert date in numerical format."
   (interactive)
-  (princ (wl-day-number (current-time-string)) (current-buffer)))
+  (princ (elmo-time-to-days (current-time)) (current-buffer)))
 
 (defun wl-score-pretty-print ()
   "Format the current score file."
@@ -1374,8 +1372,7 @@ Entering Score mode calls the value of `wl-score-mode-hook'."
   (let ((sum-buf (wl-score-edit-get-summary-buf))
        (index (nth 2 (assoc header wl-score-header-index))))
     (when (and sum-buf index)
-      (save-excursion
-       (set-buffer sum-buf)
+      (with-current-buffer sum-buf
        (wl-score-get-header header extra)))))
 
 (defun wl-score-edit-insert-number ()
@@ -1383,8 +1380,7 @@ Entering Score mode calls the value of `wl-score-mode-hook'."
   (let ((sum-buf (wl-score-edit-get-summary-buf))
        num)
     (when sum-buf
-      (if (setq num (save-excursion
-                     (set-buffer sum-buf)
+      (if (setq num (with-current-buffer sum-buf
                      (wl-summary-message-number)))
          (prin1 num (current-buffer))))))